Add support for `extraSecretEnvironmentVars` and plain `env:` values #108

Closed

pat-s wants to merge 6 commits from extraSecretEnvironmentVars into main

pat-s commented

2024-07-15 17:21:21 +00:00

(Migrated from codeberg.org)

No description provided.

wrenix commented

2024-07-20 14:57:05 +00:00

(Migrated from codeberg.org)

i like the idea of env but not of extraSecretEnvironment.
everybody could fill env then.

to be more easier, we/you could add envFrom eigher.

PS: Sorry for the delay of an review

i like the idea of `env` but not of `extraSecretEnvironment`. everybody could fill `env` then. to be more easier, we/you could add `envFrom` eigher. PS: Sorry for the delay of an review

pat-s commented

2024-07-21 10:49:42 +00:00

(Migrated from codeberg.org)

You mean

using the key envFrom in values.yml
injecting into envFrom in deployment.yaml?

You mean - using the key `envFrom` in `values.yml` - injecting into `envFrom` in `deployment.yaml`?

wrenix commented

2024-07-21 20:21:52 +00:00

(Migrated from codeberg.org)

yes, could you change it the following way?

move env to root of values.yaml (not inside of ntfy)
add envFrom to root of values.yaml and put it into deployment.yaml
remove old extraSecretEnvironmentVars

yes, could you change it the following way? - [ ] move `env` to root of `values.yaml` (not inside of ntfy) - [ ] add `envFrom` to root of `values.yaml` and put it into deployment.yaml - [ ] remove old `extraSecretEnvironmentVars`

wrenix commented

2024-07-25 23:08:12 +00:00

(Migrated from codeberg.org)

i take your commits, modify them and hope this is okay so: 1f45a8d

if yes, close this Merge Request.

i take your commits, modify them and hope this is okay so: 1f45a8d if yes, close this Merge Request.

pat-s commented

2024-07-26 07:36:47 +00:00

(Migrated from codeberg.org)

Sure, thanks for adding it! 👍